Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changing threshold for 5xx alerting rule #140

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

geekbrother
Copy link
Contributor

Description

We have an alerting rule for 5xx with a threshold of 100 in Grafana.
To catch every 5xx and not wait until it grows so much it changed to 1.
The alert message is changed to reflect threshold changes.

Resolves #139

How Has This Been Tested?

Not tested.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Oct 19, 2023
@geekbrother geekbrother marked this pull request as ready for review October 19, 2023 23:10
@geekbrother geekbrother temporarily deployed to staging October 19, 2023 23:11 — with GitHub Actions Inactive
@geekbrother geekbrother temporarily deployed to prod October 19, 2023 23:11 — with GitHub Actions Inactive
@geekbrother geekbrother temporarily deployed to staging October 23, 2023 09:28 — with GitHub Actions Inactive
@geekbrother geekbrother temporarily deployed to prod October 23, 2023 09:28 — with GitHub Actions Inactive
@geekbrother geekbrother merged commit 9cdeb97 into main Oct 23, 2023
11 checks passed
@geekbrother geekbrother deleted the max/chore/change_5xx_threshold branch October 23, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: changing threshold for 5xx alerting rule
2 participants