Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: robust migration #147

Merged
merged 11 commits into from
Oct 25, 2023
Merged

fix: robust migration #147

merged 11 commits into from
Oct 25, 2023

Conversation

chris13524
Copy link
Member

Description

Makes the migration more robust by:

  • handling the situation where any related rows that should be there that are missing, by ignoring the row
  • always lowercasing the AccountId, as some clients follow ERC-55 but others not

Resolves #146

How Has This Been Tested?

Tests

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Oct 25, 2023
geekbrother
geekbrother approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Love to see good testing here ;)

@chris13524 chris13524 merged commit 48c8814 into main Oct 25, 2023
10 checks passed
@chris13524 chris13524 deleted the fix/robust-migration branch October 25, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother geekbrother approved these changes

Assignees

@chris13524 chris13524

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: robust migration
2 participants
@chris13524 @geekbrother