-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: switch to relay webhooks #339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
force-pushed
the
fix/relay-webhooks
branch
5 times, most recently
from
January 29, 2024 22:16
6cfae89
to
10ba989
Compare
chris13524
force-pushed
the
fix/relay-webhooks
branch
from
February 8, 2024 18:21
87fd5e1
to
1953773
Compare
…into fix/relay-webhooks
geekbrother
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches from websocket client to webhooks 2.0 according to the proposed approach outlined here.
Resolves #235
Depends on #343
Remaining work:
relay_public_key
variable added to TF cloudiss
is rejected in webhook handlerFor subsequent PRs:
How Has This Been Tested?
Existing and new tests
Due Diligence