Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to relay webhooks #339

Merged
merged 30 commits into from
Feb 12, 2024
Merged

fix: switch to relay webhooks #339

merged 30 commits into from
Feb 12, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Jan 26, 2024

Description

Switches from websocket client to webhooks 2.0 according to the proposed approach outlined here.

Resolves #235

Depends on #343

Remaining work:

For subsequent PRs:

How Has This Been Tested?

Existing and new tests

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Jan 26, 2024
@chris13524 chris13524 force-pushed the fix/relay-webhooks branch 5 times, most recently from 6cfae89 to 10ba989 Compare January 29, 2024 22:16
@chris13524 chris13524 changed the base branch from main to fix/tfdocs January 29, 2024 22:16
@chris13524 chris13524 marked this pull request as ready for review February 1, 2024 22:44
@chris13524 chris13524 requested review from geekbrother and xav February 1, 2024 22:44
Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chris13524 chris13524 merged commit c245361 into main Feb 12, 2024
33 checks passed
@chris13524 chris13524 deleted the fix/relay-webhooks branch February 12, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(webhooks): implement webhooks 2.0 support
3 participants