Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update ed25519 dep #367

Merged
merged 4 commits into from
Feb 16, 2024
Merged

fix: update ed25519 dep #367

merged 4 commits into from
Feb 16, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Feb 14, 2024 •
edited
Loading

Description

Updates WalletConnectRust dep to avoid 2 versions of ed25519 dependency. Remove unnecessary dependencies because these come from WalletConnectRust now.

Remaining work:

How Has This Been Tested?

Existing tests

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Feb 14, 2024
@chris13524 chris13524 mentioned this pull request Feb 14, 2024
Merged
3 tasks
nopestack
nopestack reviewed Feb 16, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
nopestack
nopestack approved these changes Feb 16, 2024
View reviewed changes
Copy link

@nopestack nopestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but hold off on merging if the branches on the upstream repo can be merged to main before merging this one so we don't need to set branch on these deps

@chris13524 chris13524 merged commit b725054 into main Feb 16, 2024
13 checks passed
@chris13524 chris13524 deleted the fix/update-ed25519-dep branch February 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopestack nopestack nopestack approved these changes

@geekbrother geekbrother geekbrother approved these changes

Assignees

@chris13524 chris13524

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris13524 @geekbrother @nopestack