feat: mark all as read endpoint #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
reviewed
Mar 22, 2024
| Ok(StatusCode::NO_CONTENT.into_response()) | ||
| } | ||
|
|
||
| pub async fn mark_all_as_read_rate_limit( |
There was a problem hiding this comment.
Is there any reason to make this single call in a function? Since it's just used once and just called another function inside?
There was a problem hiding this comment.
It's just a pattern I've been doing when copying endpoints. Sometimes I test the rate limit. It's nice to have the config bundled here so you can see clearly what parameters are involved. No strong reason though
There was a problem hiding this comment.
I think it's also nice that it keeps biz logic separate from auxiliary processes and gives you a tidy view of what the main function is supposed to do.
There was a problem hiding this comment.
Just let's keep it simple if we can 🙌
geekbrother
approved these changes
Mar 22, 2024
nopestack
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the
/mark-all-as-readendpoint as per the docsResolves #428
How Has This Been Tested?
New tests
Due Diligence