Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable finer granularity for geo-blocking #10

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

xav
Copy link
Contributor

@xav xav commented Nov 3, 2023

Description

Allow geo-blocking on subdivision level instead of only whole country.

How Has This Been Tested?

Unit tests

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@xav xav force-pushed the chore/region_block branch from a3c1a6b to cf8118f Compare November 3, 2023 08:45
@xav xav requested a review from arein November 3, 2023 08:50
crates/geoip/src/block.rs Outdated Show resolved Hide resolved
@xav xav requested a review from heilhead November 3, 2023 10:18
Copy link
Collaborator

@heilhead heilhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for addressing the comments.

@heilhead
Copy link
Collaborator

heilhead commented Nov 3, 2023

Also, this should be a feature, not a chore it seems?

@xav xav changed the title chore: enable finer granularity for geo-blocking feat: enable finer granularity for geo-blocking Nov 3, 2023
@xav
Copy link
Contributor Author

xav commented Nov 3, 2023

Also, this should be a feature, not a chore it seems?

renamed

@xav xav merged commit 5f636b8 into main Nov 3, 2023
7 checks passed
@xav xav deleted the chore/region_block branch November 3, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants