Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade otel #17

Merged
merged 3 commits into from
Apr 16, 2024
Merged

feat: upgrade otel #17

merged 3 commits into from
Apr 16, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Apr 15, 2024

Description

Upgrade opentelemetry version to make histograms work properly by using exponential histograms.

Slack conversation

Breaking changes

  • ctx param removed from metric recording functions

How Has This Been Tested?

The histogram feature not tested, will test in Notify Server in prod.

Usage in: WalletConnect/notify-server#479

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Apr 15, 2024
@chris13524 chris13524 marked this pull request as ready for review April 15, 2024 20:27
Copy link
Collaborator

@heilhead heilhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good to see these useless contexts gone!

Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP &otel::Context::new() 🙏

@chris13524 chris13524 merged commit 52e40c6 into main Apr 16, 2024
7 checks passed
@chris13524 chris13524 deleted the feat/upgrade-otel branch April 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants