fix: enable custom histogram buckets #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
changed the title
heilhead
approved these changes
Apr 17, 2024
|
Thanks for the suggestions @heilhead, I had just thrown this together with random names. These are better names! |
chris13524
commented
Apr 17, 2024
| let meter = provider.meter(service_name); | ||
|
|
||
| global::set_meter_provider(provider); |
There was a problem hiding this comment.
Enables general use of global:: stuff. Don't think we are using this right now, but it's a best practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow customizing the builder e.g. to set custom buckets. Example here. Slack conversation
How Has This Been Tested?
Tested in Notify Server.
Due Diligence