feat: future_metrics #19
Conversation
xDarksome
force-pushed
the
feat/metrics-task-recorder
branch
from
92f39cb to
99baf63
Compare
| let metadata = Metadata::new(METADATA_TARGET, Level::INFO, None); | ||
|
|
||
| Self { | ||
| duration: r.register_histogram( |
There was a problem hiding this comment.
Are you sure this references the same counters for all Metrics instances? With opentelemetry we had to use static/shared Counter instances, otherwise the exported data was incorrect.
There was a problem hiding this comment.
the same function is being called in their macro, so I'm relatively sure
|
@heilhead I removed reporting I think the |
| state.poll_duration_max = state.poll_duration_max.max(poll_duration); | ||
| state.polls_count += 1; | ||
|
|
||
| if result.is_ready() && !state.is_finished { |
There was a problem hiding this comment.
Shouldn't you flip the state.is_finished somewhere in this block?
There was a problem hiding this comment.
yea, another copy-pasta relic. This code was in drop previously 🤡
although this would only affect fused futures probably
Description
Adds
future_metricscrate providing metrics for futures based onmetricsfacade.How Has This Been Tested?
Due Diligence