Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate gorgon, cerberus and geoip projects #5

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

xav
Copy link
Contributor

@xav xav commented Sep 28, 2023

Description

Add the gorgon, cerberus and geoip repositories as analytics, projectid and geoip crates respectively.

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@xav xav requested review from heilhead and xDarksome September 28, 2023 12:41
@xav xav changed the title Chore/gorgon cerberus chore: migrate gorgon, cerberus and geoip projects Sep 28, 2023
@xav xav force-pushed the chore/gorgon_cerberus branch from 81c001e to 6f4ddda Compare September 28, 2023 12:53
Copy link
Member

@xDarksome xDarksome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming it's just copy-pasta.
Not sure about projectid name though. It's not only about validating ids, it's a "project registry client", so maybe project_registry or just project ?

@xav
Copy link
Contributor Author

xav commented Sep 28, 2023

Looks good, assuming it's just copy-pasta. Not sure about projectid name though. It's not only about validating ids, it's a "project registry client", so maybe project_registry or just project ?

Good point, changed it to project_registry

@xav xav merged commit 67406ad into main Sep 28, 2023
7 checks passed
@xav xav deleted the chore/gorgon_cerberus branch September 28, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants