Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce relay watch webhooks #127

Merged
merged 11 commits into from
Mar 8, 2024
Merged

introduce relay watch webhooks #127

merged 11 commits into from
Mar 8, 2024

Conversation

pedrouid
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walletconnect-specs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 0:40am

@pedrouid pedrouid mentioned this pull request Aug 14, 2023
Closed
chris13524
chris13524 requested changes Aug 16, 2023
View reviewed changes
docs/specs/servers/relay/relay-server-rpc.md Outdated Show resolved Hide resolved
docs/specs/servers/relay/relay-server-rpc.md Outdated Show resolved Hide resolved
docs/specs/servers/relay/relay-server-rpc.md Outdated Show resolved Hide resolved
docs/specs/servers/relay/relay-server-rpc.md Outdated Show resolved Hide resolved
docs/specs/servers/relay/relay-server-rpc.md Outdated Show resolved Hide resolved
docs/specs/servers/relay/relay-webhooks.md Outdated Show resolved Hide resolved
chris13524
chris13524 reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add messageId as per https://walletconnect.slack.com/archives/C05ABTQSPFY/p1706640165101309

docs/specs/servers/relay/relay-server-rpc.md Outdated Show resolved Hide resolved
docs/specs/servers/relay/relay-server-rpc.md Outdated Show resolved Hide resolved
@chris13524
Copy link
Member

chris13524 commented Feb 8, 2024 •
edited
Loading

TODO:

  • Max webhook allowance
  • What type of registration results in an update vs new webhook
  • Better overall description/explanation + diagrams

@chris13524 chris13524 self-requested a review February 15, 2024 21:08
@chris13524 chris13524 requested review from arein and heilhead February 15, 2024 21:09
@chris13524 chris13524 merged commit d2c1a79 into main Mar 8, 2024
2 checks passed
@chris13524 chris13524 deleted the relay-watch-webhooks branch March 8, 2024 01:32
bkrem pushed a commit that referenced this pull request May 23, 2024
@chris13524
Merge pull request #127 from WalletConnect/relay-watch-webhooks
448fdf7 
introduce relay watch webhooks
chris13524 added a commit that referenced this pull request Jun 6, 2024
@chris13524
Merge pull request #127 from WalletConnect/relay-watch-webhooks
aee307f 
introduce relay watch webhooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris13524 chris13524 chris13524 approved these changes

@arein arein Awaiting requested review from arein

@heilhead heilhead Awaiting requested review from heilhead

@geekbrother geekbrother Awaiting requested review from geekbrother

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrouid @chris13524