Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siwe fallback #77

Merged
merged 15 commits into from
Jun 20, 2024
Merged

siwe fallback #77

merged 15 commits into from
Jun 20, 2024

Conversation

llbartekll
Copy link
Collaborator

@llbartekll llbartekll commented Jun 13, 2024

Description

in case 1ca is not supported by a wallet, w3m will fallback to personal_sign request and authenticate a user with siwe

Resolves # (issue)

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

@llbartekll llbartekll requested a review from jackpooleywc June 13, 2024 13:02
Package.swift Outdated Show resolved Hide resolved
Copy link

@jackpooleywc jackpooleywc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what caused the snapshot tests to fail?

Copy link

@llbartekll llbartekll merged commit 5d148bf into develop Jun 20, 2024
2 checks passed
@llbartekll llbartekll deleted the 1click-auth branch June 20, 2024 11:37
Copy link

@llllv llllv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FIFA_worid

Copy link

@llllv llllv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@llllv llllv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SupernLucky

# - name: Run tests
# if: matrix.type == 'unit-tests'
# shell: bash
# run: make unit_tests

# - name: Danger
# env:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SupernLucky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants