Siege rework #1
Merged
Siege rework #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orge-Remaintained # Conflicts: # src/main/java/com/flansmod/warforge/server/Siege.java
… one current use of this addition being the automatic siege failure when no attackers are detected within any of the chunks in a 3x3 centered on the siege block's chunk.
… message formatting.
…ying any other faction's ability to siege or claim this chunk for a configurable amount of time. Also cleans up combat log handling.
…otal abandon time, fix formatting issue with time left on conquered chunks, and fix array indexing off by one error with storing nbt for conquered chunks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge siege rework to mian