Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update the introduction to WasmEdge Rust SDK #143

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

apepkuss
Copy link
Contributor

@apepkuss apepkuss commented Aug 2, 2023

Explanation

Update the content of the WasmEdge Rust SDK section to the latest release 0.11.0

Related issue

NA

What type of PR is this

documentation

Proposed Changes

The latest version of WasmEdge Rust SDK has been released. The intro.md file should be updated with the info about the latest release.

Signed-off-by: Xin Liu <[email protected]>
Copy link
Collaborator

alabulei1 commented Aug 2, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall, this pull request includes three separate changes. The first one fixes outdated information in the description of the WASI-NN plugin, reflecting the correct backends. The second change involves updating the versioning table for the WasmEdge Rust SDK crates and modifying the installation instructions accordingly. Lastly, the formatting of the versioning table has been fixed.

There are no potential problems identified with any of these changes. The updates to the documentation fix typos and inaccuracies, making the information more accurate and up-to-date. However, there is room for improvement in providing additional context and explanations, particularly regarding the updated versioning table and its significance to users of the SDK.

Details

Commit 4be04514f5efdbb4cf9b857201708b556c071d68

Key changes:

  • Updated the description of the WASI-NN plugin to reflect the correct backend: PyTorch instead of OpenVINO.
  • Updated the description of the WASI-NN plugin to reflect the correct backend: TensorFlow-lite instead of OpenVINO.

Potential problems:

  • None, the changes are just fixing outdated information.

Overall, the changes in this patch fix some typos in the documentation and update the descriptions to provide accurate information about the WASI-NN plugin. There are no potential problems identified.

Commit 17f21fa5bf64b703f82ea56602c768f06d656e7c

Key changes:

  • The versioning table for the WasmEdge Rust SDK crates has been updated.
  • The installation instructions have been modified to reflect the updated versioning table.

Potential problems:

  • The patch does not provide any additional information regarding why the versioning table was updated. It might be helpful to include a brief explanation or reference to related changes.
  • The patch does not include any additional updates or improvements to the intro.md file.
  • It would be beneficial to explain the significance or purpose of the versioning table and its relevance to users of the SDK.
  • The minimum supported Rust version is mentioned, but it would be helpful to provide more context or explanation regarding why this requirement exists.

Overall, the changes appear to be straightforward updates to the versioning table and installation instructions. However, some additional explanations and context would improve the clarity and usability of the documentation.

Commit 9e04a158f2e680c1697b94402ce1af344ad5dade

Key changes:

  • The formatting of the versioning table has been fixed.

Potential problems:

  • No potential problems found.

@alabulei1 alabulei1 merged commit 30e0037 into WasmEdge:main Aug 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants