Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #144

Merged
merged 7 commits into from
Aug 11, 2023
Merged

Fix typo #144

merged 7 commits into from
Aug 11, 2023

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Aug 7, 2023

Explanation

Fixed typo and improving sentence structure.

  • Plug-in typo
  • Grammatical error
  • improved sentence structure

Related issue

What type of PR is this

/kind bug

Proposed Changes

Copy link
Collaborator

alabulei1 commented Aug 7, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary:

In this GitHub Pull Request, the proposed changes are mainly focused on fixing typos and improving the clarity and accuracy of the documentation files. The potential issues to consider include unclear guidance, lack of context or information, and the need for thorough review and confirmation of the changes.

The most important findings include the need to provide more guidance and clarification in certain areas of the documentation to make the contribution process easier for new contributors. Additionally, it is crucial to review the accuracy and completeness of the changes and ensure that the correct terminology is used consistently.

It is also important to thoroughly review the changes made in the larger patches that modify multiple files to prevent introducing new errors. Providing additional context and explanation for the changes made would be beneficial for reviewers and future maintainers.

Overall, the proposed changes appear to be minor improvements to the documentation. However, attention should be given to providing clearer guidance, ensuring accuracy and completeness, and avoiding the introduction of new errors.

Details

Commit e88c59a6d1691bd147dafed13bfa7154094c65a3

The key changes in this patch are:

  1. Fixing the sentence structure and typos in various files related to contribution guidelines and installer documentation.
  2. Updating text to improve clarity and accuracy.

Some potential problems to consider are:

  1. In contribute.md, the sentence "If there will be a significant effort, please document it as an issue and get a discussion going before starting to work on it" could be clarified to provide more guidance on what constitutes a significant effort.
  2. In contribute.md, the note about small changes states "please make sure any of the changes that goes to master will not break anything." It might be more helpful to explain how to ensure changes do not break anything.
  3. In contribute.md, the sentence "It is recommended to submit pull requests in an incremental fashion" could be expanded to provide more context on why incremental pull requests are recommended.
  4. In contribute.md, the sentence "Please ensure you add your sign-off-statement" could be clarified by providing more information on what a sign-off statement is and how to add it.
  5. In contribute.md, the sentence "The pull request description should refer to all the issues it addresses" could be expanded to provide more guidance on how to reference issues in the description.
  6. In contribute.md, the sentence "Those reviewers will do a thorough code review, looking for correctness, bugs, opportunities for improvement, documentation and comments, and coding style" could be improved by providing more specific details on what aspects of the code will be reviewed.
  7. In contribute.md, the sentence "Commit changes made in response to review comments to the same branch on your fork" could be clarified by explaining how to make the changes and update the pull request.
  8. In contribute.md, the sentence "Please open an issue on Github" should be corrected to "Please open an issue on GitHub".
  9. In contribute.md, the sentence "Good documentation is as necessary as the code itself" might benefit from explaining why good documentation is necessary.
  10. In contribute.md, the sentence "You can also design new features; please submit a proposal via the GitHub issues" could be improved by providing more information on how to submit a proposal via GitHub issues.

Overall, the changes in this patch appear to be minor improvements to the documentation. However, it might be helpful to provide more guidance or clarification in some areas to make the contribution process easier for new contributors.

Commit 0e576e34037d79bea6baa64a9087db33ea955323

The key change in this pull request is fixing several typos in the documentation files:

  1. In linux.md, the typo "setup" is corrected to "set up" in two places.
  2. In macos.md, the typo "would like to" is corrected to "want to" in one place, and "by yourself" is corrected to "yourself" in one place.
  3. In openwrt.md, the typo "of" is corrected to "or" in one place, and "openwrt" is capitalized to "OpenWrt" in multiple places. Additionally, the typo "runing" is corrected to "running" in one place.
  4. In raspberrypi.md, the typo "to add two numbers up" is corrected to "to add two numbers" in one place.

The potential problem in this pull request is that the changes are not reviewed for accuracy or completeness. It is necessary to confirm that the changes accurately reflect the intended meaning and do not introduce any new errors.

Commit affece3aa6df65ce73d2a765bbbec80705d065a6

The key changes in this patch are:

  • Fixing a typo in various documentation files related to plugins:
    • Changed "plugin" to "plug-in" in multiple places.

Potential problems:

  • The patch appears to fix a simple typo, so there shouldn't be any major problems with it. However, it would be good to double-check that all instances of the typo have been fixed and that the correct terminology is used consistently throughout the affected files.

Commit 8009c5c6c0388936de7e159eb60a35bd965673f7

Key changes made in this patch include:

  • Fixing typos in various files related to C, JavaScript, Python, Rust, and deployment documentation.
  • Updating a link in the bpf.md file.
  • Correcting the capitalization of a project name in the bpf.md file.
  • Modifying the description of the bootstrap example in the bpf.md file.

The potential problem that can be identified is that the patch is modifying a large number of files, which could increase the chance of introducing errors. Therefore, it is crucial to thoroughly review all the changes to ensure their correctness.

Commit 4979765fdf28acc7b22bb571a1832df062547900

The key change in this patch is a fix for a typo in the documentation files. The typo is fixed in the docs/develop/overview.md and docs/develop/rust/bindgen.md files.

Potential problems:

  • There is a large number of files changed in this patch, making it difficult to review and understand the full extent of the changes.
  • The patch does not provide any context or explanation for the changes made. It would be helpful to have some additional information on why this change is necessary.

Suggestion for the author:

  • It would be beneficial to provide a more detailed explanation of the changes made in the pull request description or in the commit message. This would help reviewers and future maintainers understand the purpose of the changes.

Commit e72c25fd8082e2c35f3a1caf2e5b16093ec58dd2

Key changes:

  • Fixed a typo in the documentation by updating a hyperlink URL.

Potential problems:

  • None. The patch seems to be a simple fix for a typo in a documentation file. It doesn't introduce any new code or modify existing functionality.

@mhmohona mhmohona marked this pull request as draft August 7, 2023 13:15
Signed-off-by: Mahfuza <[email protected]>
Signed-off-by: Mahfuza <[email protected]>
Signed-off-by: Mahfuza <[email protected]>
Signed-off-by: Mahfuza <[email protected]>
@mhmohona mhmohona marked this pull request as ready for review August 11, 2023 08:55
@mhmohona
Copy link
Contributor Author

@alabulei1, will you please have a look at it?

@alabulei1
Copy link
Collaborator

Thank you! @mhmohona

@alabulei1 alabulei1 merged commit b69f8f5 into WasmEdge:main Aug 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants