-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] - Added New Docs #145
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall summary: In this GitHub Pull Request titled "[Feat] - Added New Docs", multiple changes have been made to the documentation files. The changes include resolving conflicts, adding new documentation files for different use cases, adding a new category file, and fixing broken links. The potential issues and errors identified in the pull request are as follows:
The most important findings in the individual summaries are:
Overall, the changes seem to focus on improving the documentation for embedding and using WasmEdge, with updates, deletions, and additions to various files. It is important to address the potential issues and errors identified and provide sufficient context and explanations for the changes made. DetailsCommit 8ad47afda6e084ee2c0d1cab54e5ee981fd686afKey changes:
Potential problems:
Commit 95b6fb1ddb4c80a0ba8ccd2cfa3816e5293dd3daThe key changes in this pull request are:
The most important findings are:
Overall, the changes seem to be focused on improving the documentation for embedding and using WasmEdge, with some updates and restructuring of the files and content. Commit c60f8e1559130e755d142168da858acf1ba28795Key changes in the patch:
Potential problems:
Additional information or clarification from the developer is needed to properly assess the changes and identify any potential problems. Commit 8e429cbfc879326db6cd66e2e32d8dc586b56c51Key changes:
Potential problems:
Overall, this is a straightforward and necessary fix for the broken links in the documentation. It should be safe to merge. Commit bacf9d6cb83307e86285bf351e676286be30da45Key changes:
Potential problems:
Commit debacb26db42e47663a5a5f20a5af639a2d4566eKey changes:
Potential problems:
Commit 3e0a63109df98c48fe7d7c90d66732f1f683913cKey changes in the patch:
Potential problems:
Commit 73402bd9616bf1ab64e9538b211da24b1bfff7eaKey Changes:
Potential Problems:
Overall, it appears that the PR has removed certain documentation files and a category JSON file. However, there may be issues with missing or broken documentation links due to these deletions. Commit 3b73941907458aa8a4fa8924a43791fe5d0542bbKey changes in the patch:
Potential problems:
These are the most important findings in the patch. Commit c41e1b0dd3c3ed7bfa096ec73edff5993b0b19dfKey changes in the patch:
Potential problems:
Commit 12a9633dc9755714a892e7d3ceff5132fc17b3f4Key changes:
Potential Problems:
|
Oops! My bad, there are a hell lotta broken links, will fix them up :) |
@alabulei1 Could you please review this PR? |
4f36323
to
1504840
Compare
c52cdd9
to
0505ca5
Compare
Please check out my comments. Thanks. After you remove several docs, this PR can be merged. |
Also there was a CI fail, please check it out. Thanks. |
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
0505ca5
to
3e0a631
Compare
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Description:
This PR adds new docs which were missing from the book's site.