Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed->issue:147 search box is missing by replacing easyos-cn/docusau… #148

Closed
wants to merge 1 commit into from
Closed

Conversation

masterghost2002
Copy link
Contributor

Fixes the problem of search bar missing which is added in PR 31

fixes:issue 147

to fix the issue I replaced the easyos-cn/docusaurus-local-search with @cmfcmf/docusaurus-search-local which works perfectly with docusaurus v2.
Live Link for testing
Working Demo Video : Google Drive Link

Screenshot

Screenshot from 2023-08-17 20-22-03

Copy link
Collaborator

alabulei1 commented Aug 17, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 74910e579e10197b40080e5c69600f240469e37c

Key changes in the patch:

  1. Removed the "@easyops-cn/docusaurus-search-local" plugin from docusaurus.config.js.
  2. Added a new plugin "@cmfcmf/docusaurus-search-local" in docusaurus.config.js.
  3. Updated the package-lock.json file to include the "@cmfcmf/docusaurus-search-local" package and its dependencies.

Potential problems:

  1. The new plugin "@cmfcmf/docusaurus-search-local" may introduce compatibility issues with the existing codebase.
  2. The configuration of the new plugin is missing in docusaurus.config.js. It should be added with the required options.
  3. There may be conflicts or duplication of functionality between the old and new search plugins.

Recommendations:

  1. Test the new search plugin extensively to ensure it works as expected and does not cause any regressions.
  2. Update the configuration of the new plugin in docusaurus.config.js to match the previous behavior of the search functionality.
  3. Consider removing the old search plugin entirely if the new plugin covers all the required features.

@masterghost2002
Copy link
Contributor Author

Figured out why previous local search not working will be creating a new pr for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants