Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for external generators #217

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

eu-ch
Copy link
Contributor

@eu-ch eu-ch commented Dec 2, 2024

Hey @dromer, this is the external generator feature we've discussed earlier.

@dromer
Copy link
Collaborator

dromer commented Dec 3, 2024

Cool! from first look it seems alright.

I'm not 100% yet on calling the abstract class Compiler. Since atm this specific class is only used for Generators.
So maybe it should be called Generator instead :#

CompilerResp is used in various places where objects have a compile() method though. So I think I named it this because of that.

What do you think, should we name this specific group of classes Generator? I think it would be more explicit.

@dromer
Copy link
Collaborator

dromer commented Dec 3, 2024

btw I'm also going to move the Meta types to the new hvcc.types section :)

@dromer
Copy link
Collaborator

dromer commented Dec 3, 2024

ok, I made these changes, please adjust the code so it fits again :)

Also please add the feature to the CHANGELOG.md !

@eu-ch
Copy link
Contributor Author

eu-ch commented Dec 3, 2024 via email

@dromer dromer merged commit 1f6c67b into Wasted-Audio:develop Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants