Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor window-list #156

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NamorNiradnug
Copy link
Collaborator

Probably fixes #150

This patch refactors the calculation of WayfireToplevel's width. Instead of recalculating the width manually, it simply does label.set_ellipsize and label.set_max_width_chars.

Also there are a few minor style-ish changes suggested by clang-tidy.

@NamorNiradnug
Copy link
Collaborator Author

Known problem: the WayfireToplevel widget becomes too small when all the toplevels have a short titles.

@NamorNiradnug NamorNiradnug marked this pull request as draft July 9, 2023 22:56
Copy link
Contributor

@lcolitti lcolitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit simplifies things but it doesn't fix the problem. Once there are too many windows, the box starts growing, and moving to the right any widgets that are to the right of it.

For example, to the right of the window list, I have volume, network, battery, tray, and clock widgets, and if I open too many windows, the window list starts growing and pushing those widgets off the screen.

@NamorNiradnug
Copy link
Collaborator Author

This commit simplifies things but it doesn't fix the problem. Once there are too many windows, the box starts growing, and moving to the right any widgets that are to the right of it.

For example, to the right of the window list, I have volume, network, battery, tray, and clock widgets, and if I open too many windows, the window list starts growing and pushing those widgets off the screen.

Hi
Yeah, I know there's the problem, but that's why the PR is still a draft)
Thanks for your review anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High CPU usage in windowlist when it's too wide
2 participants