Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: 탑버튼 재구현(임시) #149

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Refactor: 탑버튼 재구현(임시) #149

merged 2 commits into from
Jan 13, 2024

Conversation

NohWookJin
Copy link
Collaborator

@NohWookJin NohWookJin commented Jan 12, 2024

📌 작업 내용

기존 탑버튼(sticky 사용)에서 useRef + absolute 형식으로 변경

📌 확인 사항

미적용

  • sticky - 리뷰 하단 여백 생겨서 안됨(무조건 공간이 생긴다고 합니다)
  • fixed - 반응형이 아닌 모바일 웹앱이라 안됨(부모가 무조건 viewport 기준이라 사용 안된다고 합니다)

적용

  • absolute - top 값을 동적으로 이동시키는 방식으로 변경

디바이스별 높이값이 달라서 디바이스별로 버튼이 하단에서 띄워진 높이 값이 다른데, 이 부분을 도저히 해결하지 못했습니다...

  • 412px 이상에서는 fixed 사용(레이아웃 바깥 버튼)하고, 이하에서는 absolute 사용하는 방안도 생각해봤는데 어떠신가요?
  • 머지 안해주셔도 됩니다

@NohWookJin NohWookJin self-assigned this Jan 12, 2024
@NohWookJin NohWookJin added the 🛠️ Refactor 리펙토링 관련 label Jan 12, 2024
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ten-ten-fe ✅ Ready (Inspect) Visit Preview Jan 12, 2024 5:33am

@LeHiHo LeHiHo merged commit 5af7a8c into dev Jan 13, 2024
3 checks passed
@NohWookJin NohWookJin deleted the FE-67--Mypage/View branch January 28, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Refactor 리펙토링 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants