Merge pull request #116 from WeTransfer/feature/performance-improvements

Catch obj-c exception, remove unneeded dispatch
WeTransfer · Feb 22, 2022 · ae80595 · ae80595
2 parents b6750fe + 69c7355
commit ae80595
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 10 deletions.
diff --git a/Package.swift b/Package.swift
@@ -12,9 +12,13 @@ let package = Package(name: "Diagnostics",
                       products: [
                         .library(name: "Diagnostics", type: .static, targets: ["Diagnostics"])
                         ],
+                      dependencies: [
+                        .package(url: "https://github.com/sindresorhus/ExceptionCatcher", from: "2.0.0")
+                      ],
                       targets: [
                         .target(
                             name: "Diagnostics",
+                            dependencies: ["ExceptionCatcher"],
                             path: "Sources",
                             resources: [
                                 .process("style.css"),

diff --git a/Sources/Logging/DiagnosticsLogger.swift b/Sources/Logging/DiagnosticsLogger.swift
@@ -8,6 +8,7 @@
 
 import Foundation
 import MetricKit
+import ExceptionCatcher
 
 #if os(macOS)
 import AppKit
@@ -210,9 +211,7 @@ private extension DiagnosticsLogger {
 
         inputPipe.fileHandleForReading.readabilityHandler = { [weak self] handle in
             let data = handle.availableData
-            self?.queue.async {
-                self?.handleLoggedData(data)
-            }
+            self?.handleLoggedData(data)
         }
 
         // Copy the STDOUT file descriptor into our output pipe's file descriptor
@@ -225,15 +224,23 @@ private extension DiagnosticsLogger {
     }
 
     private func handleLoggedData(_ data: Data) {
-        outputPipe.fileHandleForWriting.write(data)
+        do {
+            try ExceptionCatcher.catch { () -> Void in
+                autoreleasepool {
+                    outputPipe.fileHandleForWriting.write(data)
 
-        guard let string = String(data: data, encoding: .utf8) else {
-            return assertionFailure("Invalid data is logged")
-        }
+                    guard let string = String(data: data, encoding: .utf8) else {
+                        return assertionFailure("Invalid data is logged")
+                    }
 
-        string.enumerateLines(invoking: { [weak self] (line, _) in
-            self?.log(SystemLog(line: line))
-        })
+                    string.enumerateLines(invoking: { [weak self] (line, _) in
+                        self?.log(SystemLog(line: line))
+                    })
+                }
+            }
+        } catch {
+            print("Exception was catched \(error)")
+        }
     }
 }