This repository has been archived by the owner on Oct 26, 2024. It is now read-only.
refactor(select-union): extract to separate component #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-Levitskiy
suggested changes
May 2, 2020
src/login/login.component.ts
Outdated
|
|
||
| this.tokenService.saveToken(token); | ||
| this.alertService.success('Logged in successfully'); | ||
| if (!this.authenticationService.redirectToUnionIfNeeded(this.route.snapshot)) { |
There was a problem hiding this comment.
Can we have something like this:
Suggested change
| if (!this.authenticationService.redirectToUnionIfNeeded(this.route.snapshot)) { | |
| this.authenticationService.redirectToUnionIfNeeded(this.route.snapshot)) | |
| .orElse(() -> this.router.navigate(['/select-union'])) |
There was a problem hiding this comment.
Or with callback in parameter at least. :)
src/register/register.component.ts
Outdated
| if (error.status === 400) { | ||
| this.alertService.error(error.error); | ||
| if (data === null) { | ||
| this.alertService.error('Registration unsuccessful'); |
There was a problem hiding this comment.
Let's show server error always if it exists.
If no error message show status code description (if available somewhere).
tsvetkovv
force-pushed
the
feature/union-refactoring
branch
from
0d55b01 to
5ac6dc1
Compare
tsvetkovv
force-pushed
the
feature/union-refactoring
branch
from
5ac6dc1 to
253126c
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/Web-tree/auth/issues/106