Now a user cannot have more than 100 #29

InalDJ · 2020-12-12T09:56:41Z

records in the database

Now a user cannot have more than 100 records in the database;

Max-Levitskiy

I think we also need to add disable on add button and show message that user can't have more than 100 records.
I think we can add method getDataLimit to the service instead of hardcode it.

Max-Levitskiy · 2020-12-12T10:08:28Z

src/app/_services/data.service.ts

+  getCount(): Promise<any> {
+    return this.httpClient.get<any>(environment.backendUrl + '/data/count').toPromise();
+  }
+
  add(data: Data): Promise<any> {


I think it should be number here but not any :)

Max-Levitskiy · 2020-12-12T10:09:03Z

src/app/data/add/add.component.ts

@@ -12,6 +12,7 @@ import {isNameExists} from '../../_validators/uniq-name.validator';
  styleUrls: ['./add.component.scss']
 })
 export class AddComponent implements OnInit {
+  dataCount: string;


Number, not string

InalDjasheev added 2 commits December 12, 2020 12:52

Now a user cannot have more than 100

2c9c6f9

records in the database

Fixed issue more than 100 elements in the db;

5fbadc3

Now a user cannot have more than 100 records in the database;

Max-Levitskiy suggested changes Dec 12, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Now a user cannot have more than 100 #29

Now a user cannot have more than 100 #29

InalDJ commented Dec 12, 2020

Max-Levitskiy left a comment

Max-Levitskiy Dec 12, 2020

Max-Levitskiy Dec 12, 2020

Now a user cannot have more than 100 #29

Are you sure you want to change the base?

Now a user cannot have more than 100 #29

Conversation

InalDJ commented Dec 12, 2020

Max-Levitskiy left a comment

Choose a reason for hiding this comment

Max-Levitskiy Dec 12, 2020

Choose a reason for hiding this comment

Max-Levitskiy Dec 12, 2020

Choose a reason for hiding this comment