-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WIT.md package ids to match #222 #246
Conversation
Syntactically this looks good to me, but I'm pausing considering the more semantic implications of a change like this. These aren't entirely opaque to WIT for example because you can have: package foo:bar
interface baz {
// ...
} and somewhere else: use foo:bar/baz.{t1, t2} where the Additionally is there an idea perhaps on how to restrict filesystem layout? For example should the above be required to be something like:
Or similarly you'd have All-in-all I think I'd personally prefer to see an implementation of all of this end-to-end to suss out all the various points this needs to integrate first. That being said I do realize that this is "just" a synchronization of the binary format and WIT so it's probably not the right place to block on too much here. Basically I am not certain about this and I'd prefer to see something more end-to-end to get a better feeling for how easy it would be to generalize this syntax. Personally I prefer to do that before updating the repo but I also think it's totally ok to land this here as it hypothetically would have the 🦄 marker indicating that it's not actually implemented yet. So overall this seems ok to land, but I'd at least personally consider it in the 🦄 category until it's implemented fully in wasm-tools and/or wasmtime |
Yep, what you're suggesting is what I was imagining (except perhaps namespaces turn into directories too?). I don't think there's any urgency to have this implemented in a Preview 2 timeframe, just some modest value in illustrating future extension points to aid discussion in the registry setting, so an emoji prefix like we're discussing in #229 makes sense. |
Do you suppose it's fine to merge this now and add the emojis (and new section explaining The Plan and documenting each emoji) as part of the a future PR to address #229? |
Certainly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry forgot this
1024ad1
to
9b18f54
Compare
#222 generalized registry identifier syntax to allow both nested namespaces (
a:b:c
) and nested packages (a:b/c/d
), but didn't update WIT.md to match. This PR generalizes WIT interface names accordingly. It is still a TODO to expand WIT to allow expressing the new cases of implementation imports.