Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more documentation about types. #288

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

sunfishcode
Copy link
Member

@sunfishcode sunfishcode commented Dec 21, 2023

Add documentation describing the floating-point types, and briefly describe the difference between core-wasm numeric types and component-level numeric types.

Add more subsection headings to the prose describing the types, breaking up a sizeable quantity of text, and adding anchors that can be linked to. In particular, I've often wanted an anchor for "handle types".

And, fix the number of definition types.

@sunfishcode sunfishcode force-pushed the sunfishcode/type-docs branch from cda92a1 to 038abbf Compare December 21, 2023 18:05
Add documentation describing the floating-point types, and briefly
describe the difference between core-wasm numeric types and
component-level numeric types.

Add more subsection headings to the prose describing the types, breaking
up a sizeable quantity of text, and adding anchors that can be linked
to. In particular, I've often wanted an anchor for "handle types".

And, fix the number of definition types.
Copy link
Member

@lukewagner lukewagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for expanding on this!

(Given folks are still getting back from the holidays, I'll keep this open another week or so for feedback before merging.)

@lukewagner lukewagner merged commit 842b488 into WebAssembly:main Jan 12, 2024
1 check passed
@sunfishcode sunfishcode deleted the sunfishcode/type-docs branch January 12, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants