Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
working with gc types #317
base: main
Are you sure you want to change the base?
working with gc types #317
Changes from 2 commits
1d6566d
a48d24c
75d5925
4e98fd2
b18bd02
1f74456
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the right place to put this spec information is in CanonicalABI.md (along-side the current spec information for how non-gc works) and in
canonical-abi/definitions.py
(which has the benefit that you can write tests for it inrun_tests.py
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to rewrite
definitions.py
. The binary needs to reference an index of an already defined type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
definitions.py
is not a complete Python reference implementation but, rather, just a "suggestive" subset that describes just the lifting/lowering/built-in rules, what we do is, forcanon
definitions that take atypeidx
in the binary format, we have the correspondingcanon_*
Python function take a Python object that directly represents the type (e.g., see howcanon_lift
takes aFuncType
directly). That being said, I don't think there are any cases where you'll need to take a core wasm gc type as an immediate -- core wasm types are programmatically derived from component-level types by, e.g.,flatten_functype
which is called bycanon_lift
andcanon_lower
. Thus, I think you just need to addCoreArrayType
andCoreStructType
Python classes (analogous toCoreFuncType
) so they can be created byflatten_functype
in the appropriate cases whencx.opts.gc
is true (which you'd also add toCanonicalOptions
.