Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the "Canonical Built-ins" section of Explainer.md. #413

Merged
merged 45 commits into from
Nov 25, 2024
Merged

Reorganize the "Canonical Built-ins" section of Explainer.md. #413

merged 45 commits into from
Nov 25, 2024
+397 −91

Commits on Nov 14, 2024

  1. Reorganize the "Canonical Built-ins" section of Explainer.md. 

    This moves the signatures for the canonical builtins out of prose paragraphs
and into tables, which highlights them and simplifies the prose.

This also adds "conceptual signatures". The canonical ABI signatures are
useful when one is writing compilers or bindings generators or other tools,
while the conceptual signatures are useful for people seeking to
understand what these builtins do at a conceptual level, before thinking
about how all the various values are lowered into `i32`s.

And, the conceptual signatures in theory are independent of the ABI, so
they could be reused when new ABIs are added.

This is a follow-up to WebAssembly#407; I've re-added the
`canon` ebpf for now, removed the "Binary encoding immediates" table rows,
and tidied up the signatures to avoid using `...`.
    @sunfishcode
    sunfishcode committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    03ad944 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e234db6 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    73f24e8 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9657c3d View commit details
    Browse the repository at this point in the history

  4. Update design/mvp/Explainer.md 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0ff2d17 View commit details
    Browse the repository at this point in the history

  5. Update design/mvp/Explainer.md 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    add7458 View commit details
    Browse the repository at this point in the history

  6. Update design/mvp/Explainer.md 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b36463b View commit details
    Browse the repository at this point in the history

  7. Refactor event.poll and event.wait and types.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c3fe667 View commit details
    Browse the repository at this point in the history

  8. Rename "Conceptual signature" to "Approximate WIT signature". 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c13b9e4 View commit details
    Browse the repository at this point in the history

  9. Add documentation about the repr<T> type in the Canonical ABI.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    da51207 View commit details
    Browse the repository at this point in the history

  10. Split stream.read and stream.write into separate sections.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e417f09 View commit details
    Browse the repository at this point in the history

  11. Fix typos.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    be4e0af View commit details
    Browse the repository at this point in the history

  12. Don't use stream<T> and future<T> arguments in the builtins.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d27b8a8 View commit details
    Browse the repository at this point in the history

  13. Fix typos etc.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e27aad5 View commit details
    Browse the repository at this point in the history

  14. Add some TODOs.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    28cd369 View commit details
    Browse the repository at this point in the history

  15. Misc fixes.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    198992e View commit details
    Browse the repository at this point in the history

  16. Fix a broken link.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3c64b7c View commit details
    Browse the repository at this point in the history

  17. Update design/mvp/Explainer.md 

    Co-authored-by: Lann <[email protected]>
    @sunfishcode @lann
    sunfishcode and lann authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    917ec45 View commit details
    Browse the repository at this point in the history

  18. Add the error-context to the Canonical ABI return type for `close-wri… 

    …te`.
    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    1b55c2b View commit details
    Browse the repository at this point in the history

  19. Tidy up the formatting for a table.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    43becc0 View commit details
    Browse the repository at this point in the history

  20. Add a TODO about option<error-context>.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    88730bd View commit details
    Browse the repository at this point in the history

  21. Say T.rep instead of repr<T>.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8087cdb View commit details
    Browse the repository at this point in the history

  22. Document resource.new/.drop validation.

    @sunfishcode
    sunfishcode committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3a0a820 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Update design/mvp/Explainer.md 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    863618b View commit details
    Browse the repository at this point in the history

  2. Update design/mvp/Explainer.md 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    97dffbd View commit details
    Browse the repository at this point in the history

  3. Update design/mvp/Explainer.md 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    092b646 View commit details
    Browse the repository at this point in the history

  4. Update design/mvp/Explainer.md 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    13c48aa View commit details
    Browse the repository at this point in the history

  5. Update design/mvp/Explainer.md 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1ee9cc4 View commit details
    Browse the repository at this point in the history

  6. Change complete's payload to u32.

    @sunfishcode
    sunfishcode committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ea85b13 View commit details
    Browse the repository at this point in the history

  7. Document that stream.new returns a writable-stream.

    @sunfishcode
    sunfishcode committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b0fa9f9 View commit details
    Browse the repository at this point in the history

  8. Desecribe how status values are lowered into the canonical abi.

    @sunfishcode
    sunfishcode committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    053ab6a View commit details
    Browse the repository at this point in the history

  9. Describe status ABIs, merge read/write again.

    @sunfishcode
    sunfishcode committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f7f3672 View commit details
    Browse the repository at this point in the history

  10. Document the ..1 and the "at most" behavior.

    @sunfishcode
    sunfishcode committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4efe721 View commit details
    Browse the repository at this point in the history

  11. Document the option<error-context> in the Canonical ABI.

    @sunfishcode
    sunfishcode committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3dcaa9c View commit details
    Browse the repository at this point in the history

  12. Fix documentation links.

    @sunfishcode
    sunfishcode committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e24aeea View commit details
    Browse the repository at this point in the history

  13. Misc cleanups.

    @sunfishcode
    sunfishcode committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b2c35f5 View commit details
    Browse the repository at this point in the history

  14. More misc cleanups.

    @sunfishcode
    sunfishcode committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7869ca5 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Use more specific links, now that we have them.

    @sunfishcode
    sunfishcode committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f352c2f View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b10cbe3 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 23, 2024
    Configuration menu
    Copy the full SHA
    21ed834 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Luke Wagner <[email protected]>
    @sunfishcode @lukewagner
    sunfishcode and lukewagner authored Nov 23, 2024
    Configuration menu
    Copy the full SHA
    82d3102 View commit details
    Browse the repository at this point in the history

  4. Document that future.cancel-* report at most 1 element.

    @sunfishcode
    sunfishcode committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    689b146 View commit details
    Browse the repository at this point in the history

  5. Minor fixes.

    @sunfishcode
    sunfishcode committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0cd378b View commit details
    Browse the repository at this point in the history

  6. Reformat paragraphs.

    @sunfishcode
    sunfishcode committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b9e8bc2 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Fix fututes.* to be future.*.

    @sunfishcode
    sunfishcode committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    716bfa1 View commit details
    Browse the repository at this point in the history