Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/WDSBT-20 Custom block build process #25

Merged
merged 12 commits into from
Jun 19, 2024

Conversation

khleomix
Copy link
Contributor

Closes

WDSBT-20

Link to test

Test locally

Description

  • Create custom blocks using a template by running npm run create-block
  • Update README
  • Fix build issues with the current webpack config

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

WDSBT-.-This-is-a-tagline.mp4

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions

  1. Run npm run create-block to scaffold a block
  2. Make changes to the block styles to verify it working
  3. Run npm run build
  4. Add or edit a page and check to make sure that your new block is ready and working.

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@khleomix khleomix added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 18, 2024
@khleomix khleomix self-assigned this Jun 18, 2024
@khleomix khleomix marked this pull request as ready for review June 18, 2024 22:45
Copy link
Member

@lswilson lswilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @khleomix - approved!

@khleomix khleomix merged commit f5893f7 into main Jun 19, 2024
7 checks passed
@khleomix khleomix deleted the feature/WDSBT-20-custom-blocks branch June 19, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants