Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the issue of not being able to set the GDB path on Windows. #448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HenryRiley0
Copy link
Contributor

wechat_2024-09-25_162649_083

@HenryRiley0 HenryRiley0 force-pushed the win_gdb_path branch 2 times, most recently from 1c9b15e to 99fe264 Compare September 25, 2024 08:45
const command = process.platform === 'win32' ? 'where' : 'command -v';
execSync(`${command} ${debuggerName}`, { stdio: 'ignore' });
return true;
} } catch (error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that catch line misses it linebreak, but other than that good to go; suggestion only: "not being able to set the GDB path" -> "not being able to set the GDB binary with a path"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants