Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/3.1 - merge 428 (add id to input) #484

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Release/3.1 - merge 428 (add id to input) #484

wants to merge 9 commits into from

Conversation

flashdesignory
Copy link
Contributor

original pr: #428

@netlify Netlify
Copy link

netlify bot commented Jan 29, 2025 •
edited
Loading

✅ Deploy Preview for webkit-speedometer ready!

Name Link
🔨 Latest commit 9f60e63
🔍 Latest deploy log https://app.netlify.com/sites/webkit-speedometer/deploys/679a9d57c3ea0200082d597b
😎 Deploy Preview https://deploy-preview-484--webkit-speedometer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

julienw
julienw approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
and also thanks for the well-defined commits, this makes it easier to review!

@rniwa
Copy link
Member

rniwa commented Feb 12, 2025

What's the motivation for merging this fix into 3.1?

@flashdesignory
Copy link
Contributor Author

What's the motivation for merging this fix into 3.1?

It's a "nice to have" low risk cleanup, that doesn't change scores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camillobruni camillobruni camillobruni approved these changes

@julienw julienw julienw approved these changes

@bgrins bgrins Awaiting requested review from bgrins

@rniwa rniwa Awaiting requested review from rniwa

Assignees
No one assigned
Labels
v3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flashdesignory @rniwa @camillobruni @julienw