Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the DID ABNF - removed "$" and "!" #164

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

mwherman2000
Copy link

Removed "$" and "!" from grammar. Reset "$" back to ";" pending resolution of #163

@peacekeeper
Copy link
Member

@mwherman2000 Independent of the question whether the changes at RWoT#8 in Barcelona reflect community consensus, your PR here proposes that both did-fragment-ref and did-service-ref start with a ; character. Is this what you meant to propose?

@mwherman2000
Copy link
Author

Good catch @peacekeeper - fixed

@dmitrizagidulin
Copy link
Member

@mwherman2000 - So, the context for the proposed change from ; to $ is twofold:

  1. $ is more readable/visible than ; (which is only a few pixels away from :, which is used throughout the did).
  2. $ looks like S for "service".

In any case, I don't think this repo is the place to argue this. That paper is just that - a Rebooting paper.
There is going to be a PR to the DID spec with the ABNF from this paper, with explanations.
So, that PR would be the place for debate.

@mwherman2000
Copy link
Author

mwherman2000 commented Mar 8, 2019

As I stated here #163 .,,,

"$" is particularly problematic because "$" is already in common usage in many accepted international specifications for URLs:

OASIS/ISO OData System Query Options: http://docs.oasis-open.org/odata/odata/v4.01/cs01/part2-url-conventions/odata-v4.01-cs01-part2-url-conventions.html#_Toc505773217

In addition, these changes came from a closeted discussion behind a one-off, pay-to-play event from which no notes, attendee list, or recording are available - no record of the discussion, the participants, the justification for the changes - it doesn't represent the opinion of the broader communities that meet weekly basis every Tuesday and every second Thursday. It was a total surprise to those of us who met yesterday on the Thursday DID Resolution concall.

@mwherman2000
Copy link
Author

mwherman2000 commented Mar 8, 2019

@dmitrizagidulin These following aren't adequate justifications ...they're fluff ...especially in light of #163:

$ is more readable/visible than ; (which is only a few pixels away from :, which is used throughout the did).

This is irrelevant because the DID syntax is a syntax/procotol for developers to implement in software. It's not a human readable language.

$ looks like S for "service".

Fluff.

There is going to be a PR to the DID spec with the ABNF from this paper, with explanations.

This sounds like what was decided in Barcelona is being jammed down our throats (see #164 (comment)). Why are you not:

  1. posting the proposed changes as a did-spec issue
  2. then initiating an open discussion
  3. build community consensus
  4. then, possibly, proceed to a PR?

CC: @talltree @peacekeeper

@andrewhughes3000
Copy link
Contributor

andrewhughes3000 commented Mar 8, 2019 via email

@mwherman2000
Copy link
Author

I agree. It raises further questions why this document was placed in this repository.

@peacekeeper
Copy link
Member

@shannona I don't think it was the intention of the authors for this to be merged; you should probably revert the merge while the discussion is ongoing.

@shannona
Copy link
Contributor

Thanks; reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants