Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra parameter arguments #5

Closed
wants to merge 1 commit into from
Closed

Added extra parameter arguments #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,20 +85,19 @@ public function getUser(): User
* Fetches available Sendcloud shipping methods.
*
* @param int|null $servicePointId If passed, only shipping methods to the service point will be returned.
* @param arguments If passed, extra arguments can be added
* @return ShippingMethod[]
* @throws SendCloudClientException
*/
public function getShippingMethods(?int $servicePointId = null): array
public function getShippingMethods(?int $servicePointId = null, $arguments = []): array
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove servicePointId and replace with $arguments?

{
try {
$queryData = [];

if ($servicePointId !== null) {
$queryData['service_point_id'] = $servicePointId;
$arguments['service_point_id'] = $servicePointId;
}

$response = $this->guzzleClient->get('shipping_methods', [
'query' => $queryData,
'query' => $arguments,
]);
$shippingMethodsData = json_decode((string)$response->getBody(), true)['shipping_methods'];

Expand Down