Fix history events overlay in the editor #13900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
reviewed
Feb 17, 2025
|
I think the rendering for wide screens shout stay as it is now:
This pull request changes it to:
|
|
Yes, but this could be again done only on smaller resolutions, doing that on wide screens just puts a lot of blank space into the view. |
|
That's true, but I would argue whitespace is considered a good practice in UI design. It makes it feel less cramped or cluttered. |
|
While it is sometimes a good practice, I doubt that it would be a good practice to fit half of he content to the screen:
versus
Another good practice is UI consistency, and you've changed rendering of changes, but the suggestions are still using the existing layout. We want CSS to be reusable and not that specific so that the same layout can be reused. |
|
I see, I'll bring that layout back |
In the editor. Made it scrollable if it overflows. Close: WeblateOrg#13886
meel-hd
force-pushed
the
fix-history-events-overlap-13886
branch
from
62e4cb7 to
0e8204f
Compare
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it overlaps it will be scrollable in boundry.