Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): run tests on macos #14023

Merged
merged 2 commits into from
Feb 27, 2025
Merged

feat(ci): run tests on macos #14023

merged 2 commits into from
Feb 27, 2025

Conversation

nijel
Copy link
Member

@nijel nijel commented Feb 26, 2025

This would allow to catch issues like #14019 earlier.

@nijel nijel force-pushed the macos-ci branch 12 times, most recently from c9e33d9 to 1e3cda9 Compare February 26, 2025 15:33
@nijel nijel added this to the 5.11 milestone Feb 26, 2025
@nijel nijel modified the milestones: 5.11, 5.10.2 Feb 27, 2025
@nijel nijel marked this pull request as ready for review February 27, 2025 07:42
@nijel nijel requested a review from AliceVisek as a code owner February 27, 2025 07:42
@nijel nijel removed the request for review from AliceVisek February 27, 2025 07:42
@nijel nijel modified the milestones: 5.10.2, 5.11 Feb 27, 2025
@nijel
Copy link
Member Author

nijel commented Feb 27, 2025

Even after #14032 there is one failure in the Selenium tests.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (c35fa9e) to head (4c0c19a).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14023      +/-   ##
==========================================
- Coverage   91.01%   91.01%   -0.01%     
==========================================
  Files         608      608              
  Lines       63639    63647       +8     
  Branches     6584     6584              
==========================================
+ Hits        57920    57927       +7     
  Misses       4026     4026              
- Partials     1693     1694       +1     
Files with missing lines Coverage Δ
weblate/trans/tests/test_selenium.py 95.78% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

Using keyboard shortcuts is platform specific, so better to avoid that.
@nijel nijel merged commit a6a8bba into WeblateOrg:main Feb 27, 2025
50 checks passed
@nijel nijel deleted the macos-ci branch February 27, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant