Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): use strcoll for sorting strings instead of strxfrm #14064

Closed
wants to merge 1 commit into from
Closed

fix(utils): use strcoll for sorting strings instead of strxfrm #14064

wants to merge 1 commit into from

Conversation

nijel
Copy link
Member

@nijel nijel commented Feb 28, 2025

This one works more reliably across platforms and typically better deals with some corner cases which cannot be handled by strxfrm.

@nijel
fix(utils): use strcoll for sorting strings instead of strxfrm
37a599e 
This one works more reliably across platforms and typically better deals
with some corner cases which cannot be handled by strxfrm.
@nijel nijel added this to the 5.10.3 milestone Feb 28, 2025
@nijel nijel self-assigned this Feb 28, 2025
@nijel nijel enabled auto-merge (rebase) February 28, 2025 13:20
@nijel
Copy link
Member Author

nijel commented Feb 28, 2025

Okay, while strcoll doesn't fail on macos 15, it also doesn't sort properly, so this change brings no value.

@nijel nijel closed this Feb 28, 2025
auto-merge was automatically disabled February 28, 2025 13:58

Pull request was closed

@nijel nijel deleted the strcoll branch February 28, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
5.10.3
Development

Successfully merging this pull request may close these issues.
1 participant
@nijel