Skip to content

Commit

Permalink
Merge pull request #842 from Webperf-se/lighthouse-output
Browse files Browse the repository at this point in the history
Lighthouse Based Tests - Output file should include same source as seen in review
  • Loading branch information
7h3Rabbit authored Jan 6, 2025
2 parents 2a6f74e + e1d0bf0 commit 79d9f6e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions tests/lighthouse_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,16 +222,15 @@ def create_rating_from_audits(category, global_translation, json_content, return
weight_dict = create_weight_dict(category, json_content)
reviews = []
for audit_key, item in json_content['audits'].items():
if 'numericValue' in item:
return_dict[audit_key] = item['numericValue']

if audit_key not in weight_dict:
continue

weight = weight_dict[audit_key]
review_item = create_rating_from_audit(item, category, global_translation, weight)
if review_item is None:
continue

return_dict[audit_key] = item
reviews.append(review_item)

sorted_reviews = sorted(reviews,
Expand Down

0 comments on commit 79d9f6e

Please sign in to comment.