Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in Spectre console logging #47

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

sliekens
Copy link
Contributor

There was a Spectre.Console usage problem where the string [y/n] was being interpreted as color markup.

image

This PR fixes the bug. I also installed the Spectre.Console Roslyn Analyzers, to help detect potential usage problems in the future. I also took the liberty to add some configuration files for Visual Studio Code ( / GitHub Codespaces) users.

@sliekens
Copy link
Contributor Author

cc @ardalis

@ardalis
Copy link
Contributor

ardalis commented Aug 13, 2024

Ah thanks for that 🫡

@Webreaper Webreaper merged commit f5824c5 into Webreaper:master Aug 13, 2024
1 check passed
@Webreaper
Copy link
Owner

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants