add support for F# projects and use optimized directory traversals #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Aug 27, 2024
| @@ -8,7 +8,7 @@ namespace CentralisedPackageConverter; | |||
| public static class Output | |||
| { | |||
| public static void InfoLine(string message) => InfoLine(message, Array.Empty<object>()); | |||
| public static void InfoLine(string message, params object[] args) => AnsiConsole.MarkupLine(Markup.Escape(message), args); | |||
| public static void InfoLine(string message, params object[] args) => AnsiConsole.MarkupLine(message, args); | |||
There was a problem hiding this comment.
This change was required because the [green](project file path[/] markup wasn't being rendered.
baronfel
commented
Aug 27, 2024
Comment on lines
+404
to
+413
| if (condition != String.Empty) | ||
| { | ||
| Output.InfoLine(" Found new reference: {0} {1} with Condition {2}", | ||
| package, version.ToFullString(), condition); | ||
| } | ||
| else | ||
| { | ||
| Output.InfoLine(" Found new reference: {0} {1}", | ||
| package, version.ToFullString()); | ||
| } |
There was a problem hiding this comment.
Did some simple if/elses here to remove dangling string formats for cases where there were no conditions.
baronfel
commented
Aug 27, 2024
Comment on lines
+25
to
+39
| return new FileSystemEnumerable<FileInfo>( | ||
| directory: directory.FullName, | ||
| transform: (ref FileSystemEntry entry) => new FileInfo(entry.ToFullPath()), | ||
| options: new EnumerationOptions { RecurseSubdirectories = searchOption == SearchOption.AllDirectories } | ||
| ) | ||
| { | ||
| ShouldIncludePredicate = (ref FileSystemEntry entry) => | ||
| { | ||
| return !entry.IsDirectory && AllowedFileExtensions.Contains(Path.GetExtension(entry.FileName).ToString()); | ||
| }, | ||
| ShouldRecursePredicate = (ref FileSystemEntry entry) => | ||
| { | ||
| return !ExcludesRegex.IsMatch(entry.FileName); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
This type is hyper-optimized and the existing traversal tests still pass after the change.
|
Merged - thank you for your contribution! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This implements support for F# projects as well as using some new modern .NET directory traversals to speed up the traversal that was happening before. I've tested this on my own F# projects and it works great!
Results: