improv: Added multiline search/replace and fixed various crashes. #1911
Conversation
Previous implementation ignored everything after the first newline. Other changes include: - Added isEmpty() function that checks if editor has no content. - replaced asserts with default behavior to avoid unneeded crashes. - fixed off by one error in DeleteRange() - some crashes occurred because readily available corrective actions were not being taken. For example start/end being -1 in DeleteRange(). - At the heart of search/replace is the ability to translate from indices into the text string to line/column coordinates used for everything. To this end a function (StringIndexToCoordinates) was added to do the translation taking utf-8 chars into account. This made the recently added Utf8BytesToChars function unneeded, so it was removed. - Removed commented out code that is not useful anymore. Also removed tooltip code which is also unused. - Removed unused parameter wrapAround to FindNext().
| if (mTopMargin != oldTopMargin) { | ||
| static float savedScrollY = 0; |
There was a problem hiding this comment.
Using static here will most likely not going to work correctly if there's multiple editors shown on-screen. Move these to be member variables of the TextEditor class
There was a problem hiding this comment.
This is still problematic. Besides this, the PR looks good
There was a problem hiding this comment.
I posted an explanation as to why they are ok as static but now i dont see it anymore. I guess i don't really know how to use this user interface. so i'll try just this now.
There was a problem hiding this comment.
I see if i press resolve conversation is erases the comment? thats weird. Anyway ...
The code in question is the one responsible for having the find-replace popup behave like vscode. When using find-replace popup one may open the window as Find, expand it to Replace, shrink it back to Find and close the window. Through those event the variables cycle through 2 or 3 values which are always the same.
Because the window is a popup whenever it is opened for one editor it must be closed before other editors can get focus so the variables will always be reinitialized in the complete open-close cycle so the variables can't be used by several editors at the same time. Being static makes the code simpler as the variables are initialized once and then keep their values between calls. It is impossible to have more than one search-replace window opened so it should be safe to use static variables.
If after reading this you still have issues I can look into converting them to non-static, but the simple naive change that I first tried broke the popup in away that empty lines are added at the end of the file when the popup was opened and then closed. I tested it in every way I can't think and besides an unavoidable artifact when the end of the file is in view when the window is opened it works as expected. The artifact is a consequence of how the maximum scroll value works.
Problem description
Previous implementation ignored everything after the first newline. Other changes include: