Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Bot Additions #107

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New Bot Additions #107

wants to merge 3 commits into from

Conversation

vincentkoc
Copy link

  • SEO Moz.com Roger Bot
  • SEO Majestic SEO Bot
  • HTTPUnit for Java

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.976% when pulling 2ebfbc6 on koconder:dev-newbots into 9c6ad8e on WhichBrowser:master.

@NielsLeenheer
Copy link
Member

My apologies for not responding earlier. If a PR change the detection, it also need to be accompanied with tests. That way we can ensure that the change will keep working in the future.

@vincentkoc
Copy link
Author

@NielsLeenheer this is to help patch an issue from a dependency to this library. Its almost a year old, could you help with the unit tests?

@summercms
Copy link
Contributor

I already added Moz and Majestic I could create a new pr for the HTTPUnit for Java

@NielsLeenheer you might as well close this pr and I will create a new pr for the HTTPUnit for Java tomorrow for you.

This was referenced Aug 19, 2020
Closed
Closed
@summercms summercms mentioned this pull request Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincentkoc @coveralls @NielsLeenheer @summercms