-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Manual Pinned Programs #539
Closed
PortableProgrammer
wants to merge
37
commits into
Whisky-App:main
from
PortableProgrammer:feat-manual-pins
Closed
[Feat] Manual Pinned Programs #539
PortableProgrammer
wants to merge
37
commits into
Whisky-App:main
from
PortableProgrammer:feat-manual-pins
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftLint complained about >400 lines in `BottleView.swift`.
Update Localizable.xstrings for the the German language
@PortableProgrammer Rebase needed |
* Move to seperate view, change focus handeling * Fixessss * Fix crash when deleting * Prevent several empty keys * Not ideal, but it works * Sorting and edge case * Few small tweaks * Wrap around on submit
Will rebase this evening. |
SwiftLint complained about >400 lines in `BottleView.swift`.
…ky into feat-manual-pins
Replaced by #608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI elements for manually pinning programs, useful for built-in Windows utilities, portable applications, applications that are not installed within the
Program Files
orProgram Files (x86)
directories, applications that don't create Start Menu shortcuts, etc.Fixes #405
In the main Bottle view:
Pin Program
button when the pinned programs list is emptyManual Pinning UI and Result Examples
Pinned programs are intelligently added to the Installed Programs list for configuration parity.
Attempts to pin the same program multiple times are detected and disallowed.