Migrate to cw-assets v3 and cw-storage-plus v1.2.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFable
approved these changes
Jun 10, 2024
| WHITELIST | ||
| .load(deps.storage, asset_key.clone()) | ||
| .load(deps.storage, &asset) |
There was a problem hiding this comment.
Should we not keep the AssetInfoKey ?
To be fair it is just a type overwriting a type but how do you feel
There was a problem hiding this comment.
AssetInfoKey does not exist in cw-assets v3, that's the whole point of this migration, should probably have mentioned it above
| let total_reward_distributed = Decimal::from_atomics(rewards_collected, 0)? | ||
| * asset_distribution.distribution | ||
| / total_distribution; | ||
|
|
||
| // If there are no balances, we stop updating the rate. This means that the emissions are not directed to any stakers. | ||
| let total_balance = TOTAL_BALANCES | ||
| .load(deps.storage, asset_key.clone()) | ||
| .load(deps.storage, &asset_distribution.asset) |
There was a problem hiding this comment.
Double check but maybe this causes migrations. If not then I am happy with it
There was a problem hiding this comment.
all of it causes migrations 😅
| } | ||
|
|
||
| fn migrate_whitelist_map(deps: DepsMut) -> Result<(), ContractError> { | ||
| const OLD_WHITELIST: Map016<cw_asset_v2::AssetInfoKey, ChainId> = Map016::new("whitelist"); |
There was a problem hiding this comment.
Does cw_asset_v3 not have an assetKey?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the cw-assets and cw-storage-plus dependencies of the alliance-hub contract in preparation to tweaks for eris' ve3-contracts.