Nguyen/ibc hooks #197
Merged
Nguyen/ibc hooks #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use final release of wasmd v0.40.0
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.3 to 1.8.4. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.3...v1.8.4) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…modules/github.com/stretchr/testify-1.8.4 build(deps): bump github.com/stretchr/testify from 1.8.3 to 1.8.4
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.15.0 to 1.16.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.15.0...v1.16.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…modules/github.com/spf13/viper-1.16.0 build(deps): bump github.com/spf13/viper from 1.15.0 to 1.16.0
Invalid memory address or nil pointer dereference when collect-gentxs
add pfm to transfer stack
expertdicer
requested review from
PolkachuIntern,
faddat,
Sen-Com,
kerber0x,
0xFable,
vuong177,
pysel and
hieuvubk
as code owners
|
@anhductn2001 I think we should add IBC hook test to e2e testing. |
|
Ok @vuong177, I will |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if err != nil { | ||
| // If the ack is not a json object, error | ||
| return err | ||
| } | ||
|
|
||
| sudoMsg := []byte(fmt.Sprintf( | ||
| `{"ibc_lifecycle_complete": {"ibc_ack": {"channel": "%s", "sequence": %d, "ack": %s, "success": %s}}}`, | ||
| packet.SourceChannel, packet.Sequence, ackAsJson, success)) | ||
| packet.SourceChannel, packet.Sequence, ackAsJSON, success)) |
Check failure
Code scanning / CodeQL
Potentially unsafe quoting
|
I think that this PR is good to go, for the v47 version of Migaloo. |
faddat
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
This PR continues the progress of #150
Related Issues
#138
#150
Checklist:
Update index.md)golangci-lint run ./... --fix.