-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.0: fix pfm and add ibc hooks #232
Conversation
…ter-stack Add pfm to ibc stack
Add ibchooks store key to upgrade
…upgrade-to-app Add v3 upgrade to app
I think after merging the #246, we are good to go. cc: @faddat @hoangdv2429 |
Agree. In the future please work with other codeowners if I'm not available, but looks like great work guys! <3 |
…r-fix Remove unused upgrades and comment
In constants.go for the v3 upgrade, I noticed that we had the version set as v2.2.5. I've changed that to v3.0.0 |
moment while I check on the contract keeper |
I made changes after the review, and would like a re-review.
@expertdicer - sir, I think that in my own re-review, I found two issues:
I have fixed both of these and re-requested your review. Thanks! <3 -Jacob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add this after intialize value for TransferKeepr in app.go line 564: app.RouterKeeper.SetTransferKeeper(app.TransferKeeper)
set transfer keeper for pfm
…re-typo gitignore typo
Description and Motivation
This is the full v3 upgrade for migaloo, including upgrade handlers. It should not yet be merged, because we want to check over the upgrade hander before merge. On merge, this will form a new testnet and mainnet. Governance proposal slated to go up 9/16/2023
Related Issues
Checklist:
Update index.md
)golangci-lint run ./... --fix
.