Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: integration test #300

Merged
merged 10 commits into from
Jan 9, 2024
Merged

test: integration test #300

merged 10 commits into from
Jan 9, 2024

Conversation

duvbell
Copy link
Contributor

@duvbell duvbell commented Jan 2, 2024 •
edited
Loading

Description and Motivation

Add integration tests for these modules

  • alliance
  • token factory
  • ica
  • ibc hooks

Related Issues

issue tracker

Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly golangci-lint run ./... --fix.

@duvbell duvbell changed the base branch from release/v3.0.x to develop January 2, 2024 08:30
@duvbell duvbell marked this pull request as draft January 2, 2024 08:32
@duvbell duvbell marked this pull request as ready for review January 9, 2024 09:03
@duvbell duvbell force-pushed the add-integration-tests branch from 69bc17e to 3666b15 Compare January 9, 2024 09:05
hoank101
hoank101 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@hoank101 hoank101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoank101 hoank101 merged commit 706a0ed into develop Jan 9, 2024
12 of 15 checks passed
@hoank101 hoank101 deleted the add-integration-tests branch March 22, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoank101 hoank101 hoank101 approved these changes

@PolkachuIntern PolkachuIntern Awaiting requested review from PolkachuIntern

@faddat faddat Awaiting requested review from faddat

@Sen-Com Sen-Com Awaiting requested review from Sen-Com

@kerber0x kerber0x Awaiting requested review from kerber0x

@0xFable 0xFable Awaiting requested review from 0xFable

@hieuvubk hieuvubk Awaiting requested review from hieuvubk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duvbell @hoank101