feat(smart-contracts): add tests for add & remove swap route failing …

…scenarios
White-Whale-Defi-Platform · Apr 19, 2024 · b6422fa · b6422fa
1 parent 3faf786
commit b6422fa
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/contracts/liquidity_hub/pool-manager/src/router/commands.rs b/contracts/liquidity_hub/pool-manager/src/router/commands.rs
@@ -170,8 +170,9 @@ pub fn execute_swap_operations(
 
 pub fn add_swap_routes(
     deps: DepsMut,
-    env: Env,
-    sender: Addr,
+    // TODO: still need to save the swap route creator into state
+    _env: Env,
+    _sender: Addr,
     swap_routes: Vec<SwapRoute>,
 ) -> Result<Response, ContractError> {
     let mut attributes = vec![];

diff --git a/contracts/liquidity_hub/pool-manager/src/tests/integration_tests.rs b/contracts/liquidity_hub/pool-manager/src/tests/integration_tests.rs
@@ -1315,6 +1315,17 @@ mod router {
             }));
         });
 
+        // Re-add the same swap route should fail
+        suite.add_swap_routes(creator.clone(), vec![swap_route_1.clone()], |result| {
+            assert_eq!(
+                result.unwrap_err().downcast_ref::<ContractError>(),
+                Some(&ContractError::SwapRouteAlreadyExists {
+                    offer_asset: "uwhale".to_string(),
+                    ask_asset: "uusd".to_string()
+                })
+            );
+        });
+
         // Let's query for the swap route
         suite.query_swap_routes(|result| {
             assert_eq!(result.unwrap().swap_routes[0], swap_route_1);
@@ -1471,6 +1482,17 @@ mod router {
         suite.query_swap_routes(|result| {
             assert_eq!(result.unwrap().swap_routes.len(), 0);
         });
+
+        // Re-remove the same swap route should fail
+        suite.remove_swap_routes(creator.clone(), vec![swap_route_1.clone()], |result| {
+            assert_eq!(
+                result.unwrap_err().downcast_ref::<ContractError>(),
+                Some(&ContractError::NoSwapRouteForAssets {
+                    offer_asset: "uwhale".to_string(),
+                    ask_asset: "uusd".to_string()
+                })
+            );
+        });
     }
 }