Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flow expansion #191

Merged
merged 7 commits into from
Sep 22, 2023
Merged

feat: flow expansion #191

merged 7 commits into from
Sep 22, 2023

Conversation

kerber0x
Copy link
Contributor

@kerber0x kerber0x commented Jun 9, 2023

Description and Motivation

This PR adds the functionality to expand an active incentive flow.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

@kerber0x kerber0x force-pushed the feat/flow-expansion branch from 28c3a2b to a639f1c Compare June 9, 2023 16:14
@kerber0x kerber0x added the enhancement New feature or request label Jun 13, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 96.83% and project coverage change: +0.27% 🎉

Comparison is base (8be0687) 94.22% compared to head (5972d45) 94.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   94.22%   94.50%   +0.27%     
==========================================
  Files         215      217       +2     
  Lines       23311    24822    +1511     
==========================================
+ Hits        21965    23457    +1492     
- Misses       1346     1365      +19     
Files Changed Coverage Δ
.../liquidity_hub/pool-network/incentive/src/error.rs 0.00% <ø> (ø)
...ub/pool-network/incentive/src/tests/integration.rs 98.18% <ø> (+0.38%) ⬆️
...dity_hub/pool-network/incentive/src/tests/suite.rs 85.95% <83.33%> (+0.07%) ⬆️
...iquidity_hub/pool-network/incentive/src/helpers.rs 89.79% <88.00%> (-1.88%) ⬇️
.../pool-network/incentive/src/execute/expand_flow.rs 95.12% <95.12%> (ø)
.../liquidity_hub/pool-network/incentive/src/claim.rs 97.64% <100.00%> (+0.24%) ⬆️
...quidity_hub/pool-network/incentive/src/contract.rs 100.00% <100.00%> (ø)
...b/pool-network/incentive/src/execute/close_flow.rs 100.00% <100.00%> (ø)
...ub/pool-network/incentive/src/execute/open_flow.rs 98.80% <100.00%> (+0.07%) ⬆️
...hub/pool-network/incentive/src/queries/get_flow.rs 100.00% <100.00%> (+16.66%) ⬆️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -172,7 +172,7 @@ pub fn migrate(mut deps: DepsMut, _env: Env, _msg: MigrateMsg) -> Result<Respons
});
}

if storage_version < Version::parse("1.0.4")? {
if storage_version < Version::parse("1.0.6")? {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to keep a record somewhere of what changes between versions just for your own reference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should probably add a changelog file to the repo, good point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should probably add a changelog file to the repo, good point.

@kerber0x kerber0x merged commit 0dfcd12 into main Sep 22, 2023
5 checks passed
@kerber0x kerber0x deleted the feat/flow-expansion branch September 22, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants