Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make fee aggregation permissionless #226

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

kerber0x
Copy link
Contributor

@kerber0x kerber0x commented Dec 5, 2023

Description and Motivation

This PR makes the fee aggregation permissionless on the fee collector contract.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

0xFable
0xFable previously approved these changes Dec 5, 2023
Copy link
Contributor

@0xFable 0xFable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 question but overall looks good.

@kerber0x
Copy link
Contributor Author

kerber0x commented Dec 5, 2023

Will be fixing tests soon.

@kerber0x kerber0x force-pushed the fix/permissionless-fee-aggregation branch from 411349f to 66793ef Compare December 6, 2023 11:24
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b64cc7e) 94.48% compared to head (66793ef) 94.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   94.48%   94.51%   +0.02%     
==========================================
  Files         218      218              
  Lines       24659    24720      +61     
==========================================
+ Hits        23299    23364      +65     
+ Misses       1360     1356       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kerber0x kerber0x merged commit 3e4b14f into main Dec 6, 2023
6 checks passed
@kerber0x kerber0x deleted the fix/permissionless-fee-aggregation branch December 6, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants