Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove add_native_decimals balance check #233

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

kerber0x
Copy link
Contributor

Description and Motivation

This PR removes the add_native_decimals balance check, since the pool factory is permissioned there's no risk on this one. Also, this change will allow allowing another wallet to create pools via authz without the need to send any balances to the contract.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

…decimals check to allow other accounts via authz call this message without sending funds
0xFable
0xFable previously approved these changes Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec16d59) 94.51% compared to head (a5ee21c) 94.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         218      218           
  Lines       24720    24708   -12     
=======================================
- Hits        23364    23354   -10     
+ Misses       1356     1354    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kerber0x kerber0x merged commit 6472475 into main Dec 19, 2023
6 checks passed
@kerber0x kerber0x deleted the feat/remove-add-decimals-check branch December 19, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants