Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: forces the protobuf version to be 3.2.0 #256

Merged
merged 1 commit into from
Jan 25, 2024
Merged

chore: forces the protobuf version to be 3.2.0 #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ cw20 = "1.0.1"
cw20-base = { version = "1.1.0", features = ["library"] }
cw-storage-plus = "1.1.0"
cw-utils = "1.0.1"
protobuf = { version = "3.2.0", features = ["with-bytes"] }
protobuf = { version = "=3.2.0", features = ["with-bytes"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the equal force it, I thought just specifying a dep with a version was enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too! Apparently omitting it equals ^, which is basically means:

1.2.3 := >=1.2.3, <2.0.0

So the minimum version becomes 3.2.0 in our case, but it can go up to 4.0.0 (excluding). I remember we got issues with protobuf in the past because suddenly some new version appeared. The = forces the crate (and its dependencies) to use that version even if another package could pull a newer version.

See this for reference:
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-path-dependencies

schemars = "0.8.12"
semver = "1.0.12"
serde = { version = "1.0.145", default-features = false, features = ["derive"] }
Expand Down
Loading